Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp runtimeCaching.options to account for new plugins usage. #1095

Merged
merged 1 commit into from
Dec 1, 2017

Conversation

jeffposnick
Copy link
Contributor

@workbox-pr-bot
Copy link
Collaborator

PR-Bot Size Plugin

Changed File Sizes

File Before After Change GZipped
packages/workbox-cli/build/app.js 4.57 KB 4.49 KB -2% 1.61 KB
packages/workbox-google-analytics/build/workbox-google-analytics.prod.js 1.94 KB 1.92 KB -1% 956 B
packages/workbox-sw/build/workbox-sw.js 1.43 KB 1.35 KB -6% 737 B
packages/workbox-webpack-plugin/build/index.js 7.29 KB 7.46 KB +2% 2.49 KB

New Files

No new files have been added.

All File Sizes

View Table
File Before After Change GZipped
packages/workbox-background-sync/build/workbox-background-sync.prod.js 3.17 KB 3.17 KB 0% 1.34 KB
packages/workbox-broadcast-cache-update/build/workbox-broadcast-cache-update.prod.js 1.05 KB 1.05 KB 0% 565 B
packages/workbox-build/build/index.js 16.62 KB 16.62 KB 0% 5.07 KB
packages/workbox-cache-expiration/build/workbox-cache-expiration.prod.js 3.13 KB 3.13 KB 0% 1.16 KB
packages/workbox-cacheable-response/build/workbox-cacheable-response.prod.js 593 B 593 B 0% 343 B
packages/workbox-cli/build/app.js 4.57 KB 4.49 KB -2% 1.61 KB
packages/workbox-cli/build/bin.js 2.53 KB 2.53 KB 0% 1.07 KB
packages/workbox-core/build/workbox-core.prod.js 6.67 KB 6.67 KB 0% 2.61 KB
packages/workbox-google-analytics/build/workbox-google-analytics.prod.js 1.94 KB 1.92 KB -1% 956 B
packages/workbox-precaching/build/workbox-precaching.prod.js 4.75 KB 4.75 KB 0% 1.84 KB
packages/workbox-routing/build/workbox-routing.prod.js 2.74 KB 2.74 KB 0% 1.23 KB
packages/workbox-strategies/build/workbox-strategies.prod.js 3.22 KB 3.22 KB 0% 1.00 KB
packages/workbox-sw/build/workbox-sw.js 1.43 KB 1.35 KB -6% 737 B
packages/workbox-webpack-plugin/build/index.js 7.29 KB 7.46 KB +2% 2.49 KB

Workbox Aggregate Size Plugin

☠️ WARNING ☠️

We are using 150% of our max size budget.

Total Size: 21.92KB
Percentage of Size Used: 150%

Gzipped: 8.72KB

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f319ddf on runtime-caching-plugins-update into ** on v3**.

@jeffposnick
Copy link
Contributor Author

This PR takes the current functionality in v3 and pretty directly migrates it to support the new Plugin-based approach to configuring everything.

I also filed #1096 to track a larger discussion about runtimeCaching.options in v3, and that might lead to follow-up PRs depending on what the resolution is.

@jeffposnick jeffposnick merged commit 0342601 into v3 Dec 1, 2017
@jeffposnick jeffposnick deleted the runtime-caching-plugins-update branch December 1, 2017 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants