-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The service worker navigation preload request was cancelled before 'preloadResponse' settled. If you intend to use 'preloadResponse', use waitUntil() or respondWith() to wait for the promise to settle. #2883
Comments
Hello! From reading your code, my guess is that you're seeing this with the second navigation route, the one using the I believe that the you're seeing is logged by Chrome whenever Adding a
So basically, unless you're actually seeing unexpected behavior, I think the explanation for the logged message is that it's effectively a false positive, motivated by Chrome attempting to log something helpful. We can revisit this if that assessment seems incorrect. |
I am getting canceled request for new cache and not updated cache on second navigation (best visible on refresh) |
CC: @Snugug who might be running into something similar. |
Okay, sorry for initially assuming that this was just logging noise. I was able to reproduce failures to update the cache during the revalidate step of The fix is adding in a |
@jeffposnick Thanks a lot 🙂 |
This fix is now in the https://github.com/GoogleChrome/workbox/releases/tag/v6.5.0 release. |
Background
I am trying to use a navigationPreload and a cache data by
StaleWhileRevalidate
strategy for a navigation request.Problem
I am getting an error message:
and cache is not updated
Finding
I think for this case
this.waitUntil
is missing to wait for a responseworkbox/packages/workbox-strategies/src/StrategyHandler.ts
Line 240 in 0b5d9d8
Question
I am doing something wrong in my code or this finding is a needed fix?
Thank you so much for creating this great library.
The text was updated successfully, but these errors were encountered: