Add a waitUntil() to the SWR strategy #3015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @tropicadri @philipwalton
CC: @Snugug
Fixes #2883
This additional
waitUntil()is needed because otherwise, by the time a navigation preload response might be consumed, theFetchEventwill have already completed execution. When S-W-R is used in a navigation route with navigation preload enabled, this could cause an initially cached response to never get revalidated.(I spent a few hours trying to put together an integration test that would have caught the initial problem, but I did not have any luck, so I'm just checking in the fix that I manually verified.)