Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming workbox-runtime-caching to workbox-strategies #1046

Merged
merged 2 commits into from
Nov 15, 2017
Merged

Conversation

gauntface
Copy link

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 64898a0 on strategies-rename into ** on v3**.

Copy link
Contributor

@jeffposnick jeffposnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the test/workbox-runtime-caching/ directory to test/workbox-strategies/?

Should be 👍 with that change.

@gauntface
Copy link
Author

cc @jeffposnick here you go.

@workbox-pr-bot
Copy link
Collaborator

PR-Bot Size Plugin

Changed File Sizes

File Before After Change GZipped
packages/workbox-sw/build/workbox-sw.js 1.36 KB 1.35 KB -0% 740 B

New Files

File Size GZipped
packages/workbox-strategies/build/workbox-strategies.prod.js 2.95 KB 1.01 KB

All File Sizes

View Table
File Before After Change GZipped
packages/workbox-background-sync/build/workbox-background-sync.prod.js 2.74 KB 2.74 KB 0% 1.27 KB
packages/workbox-build/build/index.js 16.52 KB 16.52 KB 0% 5.04 KB
packages/workbox-cache-expiration/build/workbox-cache-expiration.prod.js 2.53 KB 2.53 KB 0% 1.07 KB
packages/workbox-cli/build/app.js 3.93 KB 3.93 KB 0% 1.48 KB
packages/workbox-cli/build/bin.js 2.53 KB 2.53 KB 0% 1.07 KB
packages/workbox-core/build/workbox-core.prod.js 5.34 KB 5.34 KB 0% 2.39 KB
packages/workbox-google-analytics/build/workbox-google-analytics.prod.js 1.87 KB 1.87 KB 0% 917 B
packages/workbox-precaching/build/workbox-precaching.prod.js 4.00 KB 4.00 KB 0% 1.74 KB
packages/workbox-routing/build/workbox-routing.prod.js 2.74 KB 2.74 KB 0% 1.24 KB
packages/workbox-strategies/build/workbox-strategies.prod.js 2.95 KB 1.01 KB
packages/workbox-sw/build/workbox-sw.js 1.36 KB 1.35 KB -0% 740 B
packages/workbox-webpack-plugin/build/index.js 9.67 KB 9.67 KB 0% 2.88 KB

Workbox Aggregate Size Plugin

☠️ WARNING ☠️

We are using 126% of our max size budget.

Total Size: 18.47KB
Percentage of Size Used: 126%

Gzipped: 7.99KB

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 82.933% when pulling 69dcd78 on strategies-rename into d0d8b12 on v3.

@gauntface gauntface merged commit f645dd4 into v3 Nov 15, 2017
@gauntface gauntface deleted the strategies-rename branch November 15, 2017 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants