v2: Warn on usage of Express-style wildcard characters #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauntface
reviewed
Nov 15, 2017
| const valueToCheck = capture.startsWith('http') ? | ||
| new URL(capture, location).pathname : | ||
| capture; | ||
| const match = valueToCheck.match(new RegExp(`${wildcards}`)); |
There was a problem hiding this comment.
Nit: Change match to possibleExpressString
gauntface
reviewed
Nov 15, 2017
| logHelper.warn({ | ||
| message: `registerRoute() was called with a string containing an ` + | ||
| `Express-style wildcard character. While this is currently ` + | ||
| `supported, it will no longer be treated as a wildcard match in ` + |
There was a problem hiding this comment.
Simplify the message here.
Suggestion:
registerRoute() was called with a string containing an express-style wild card character. In the next version of Workbox express style routes won't be supported by default, instead strings will have to be exact matches. Please switch to regulare expressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @addyosmani @gauntface
Fixes #1011
Using
warn()vs. a lower log level is up for negotiation.I was planning on writing a test to make sure that
logHelper.warn()was getting called, but then I realized we had issues in v2 with stubbing out code that is internal to the bundle. I can't find any examples of stubbing outlogHelpermethods, but if someone knows of some prior art, I'll copy it and add in some tests.