Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins changes #1084

Merged
merged 5 commits into from
Nov 30, 2017
Merged

Plugins changes #1084

merged 5 commits into from
Nov 30, 2017

Conversation

gauntface
Copy link

R: @jeffposnick @addyosmani @gauntface

Fixes #1071

Changes plugins to Plugin for relevant modules and removes the config to plugin builder.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 68b5233 on plugins-changes into ** on v3**.

Copy link
Contributor

@jeffposnick jeffposnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the equivalent naming change to workbox-background-sync as part of this PR? I know it's not implicitly initialized by workbox-strategies, but it would be nice to be consistent.

@jeffposnick
Copy link
Contributor

Changes look good, modulo whatever testing issues you were seeing.

@gauntface
Copy link
Author

Raised issue for testing errors.: #1086

@workbox-pr-bot
Copy link
Collaborator

PR-Bot Size Plugin

Changed File Sizes

File Before After Change GZipped
packages/workbox-background-sync/build/workbox-background-sync.prod.js 3.17 KB 3.17 KB -0% 1.34 KB
packages/workbox-broadcast-cache-update/build/workbox-broadcast-cache-update.prod.js 1.07 KB 1.05 KB -2% 565 B
packages/workbox-cache-expiration/build/workbox-cache-expiration.prod.js 3.15 KB 3.13 KB -0% 1.16 KB
packages/workbox-cacheable-response/build/workbox-cacheable-response.prod.js 610 B 593 B -3% 343 B
packages/workbox-google-analytics/build/workbox-google-analytics.prod.js 1.93 KB 1.92 KB -0% 956 B
packages/workbox-strategies/build/workbox-strategies.prod.js 3.54 KB 3.22 KB -9% 1.00 KB

New Files

No new files have been added.

All File Sizes

View Table
File Before After Change GZipped
packages/workbox-background-sync/build/workbox-background-sync.prod.js 3.17 KB 3.17 KB -0% 1.34 KB
packages/workbox-broadcast-cache-update/build/workbox-broadcast-cache-update.prod.js 1.07 KB 1.05 KB -2% 565 B
packages/workbox-build/build/index.js 16.62 KB 16.62 KB 0% 5.07 KB
packages/workbox-cache-expiration/build/workbox-cache-expiration.prod.js 3.15 KB 3.13 KB -0% 1.16 KB
packages/workbox-cacheable-response/build/workbox-cacheable-response.prod.js 610 B 593 B -3% 343 B
packages/workbox-cli/build/app.js 4.49 KB 4.49 KB 0% 1.61 KB
packages/workbox-cli/build/bin.js 2.53 KB 2.53 KB 0% 1.07 KB
packages/workbox-core/build/workbox-core.prod.js 6.67 KB 6.67 KB 0% 2.61 KB
packages/workbox-google-analytics/build/workbox-google-analytics.prod.js 1.93 KB 1.92 KB -0% 956 B
packages/workbox-precaching/build/workbox-precaching.prod.js 4.75 KB 4.75 KB 0% 1.84 KB
packages/workbox-routing/build/workbox-routing.prod.js 2.74 KB 2.74 KB 0% 1.23 KB
packages/workbox-strategies/build/workbox-strategies.prod.js 3.54 KB 3.22 KB -9% 1.00 KB
packages/workbox-sw/build/workbox-sw.js 1.35 KB 1.35 KB 0% 737 B
packages/workbox-webpack-plugin/build/index.js 7.46 KB 7.46 KB 0% 2.49 KB

Workbox Aggregate Size Plugin

☠️ WARNING ☠️

We are using 150% of our max size budget.

Total Size: 21.92KB
Percentage of Size Used: 150%

Gzipped: 8.72KB

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 83.402% when pulling e291db3 on plugins-changes into 2445dea on v3.

@gauntface gauntface merged commit fb3e8aa into v3 Nov 30, 2017
@gauntface gauntface deleted the plugins-changes branch November 30, 2017 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants