-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugins changes #1084
Plugins changes #1084
Conversation
Changes Unknown when pulling 68b5233 on plugins-changes into ** on v3**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make the equivalent naming change to workbox-background-sync
as part of this PR? I know it's not implicitly initialized by workbox-strategies
, but it would be nice to be consistent.
1245ce2
to
e70647a
Compare
Changes look good, modulo whatever testing issues you were seeing. |
Raised issue for testing errors.: #1086 |
PR-Bot Size PluginChanged File Sizes
New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size Plugin☠️ WARNING ☠️We are using 150% of our max size budget. Total Size: 21.92KB Gzipped: 8.72KB |
R: @jeffposnick @addyosmani @gauntface
Fixes #1071
Changes plugins to
Plugin
for relevant modules and removes the config to plugin builder.