v3: workbox-range-requests module #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauntface
approved these changes
Dec 6, 2017
| import './_version.mjs'; | ||
|
|
||
| /** | ||
| * A class implementing the `cachedResponseWillBeUsed` lifecycle callback. |
There was a problem hiding this comment.
This description should cover the purpose of the class, not the implementation details.
The range request plugin makes it easy for a Request with a 'range' header to be forfilled by a cached response.
It does this by intercepting thecachedResponseWillBeUsedplugin callback and returning the appropriate subset of the cached Response body.
| * @param {Request} options.request The original request, which may or may not | ||
| * contain a Range: header. | ||
| * @param {Response} options.cachedResponse The complete cached response. | ||
| * @return {Promise<Response>} If request contains a Range: header, then |
There was a problem hiding this comment.
Nit, could you shorten this to: "If request contains a 'Range' header, then a new Response with status 206 whose body is a subset of cachedResponse is returned, otherwise cachedResponse is returned as-is."
PR-Bot Size PluginChanged File Sizes
New Files
All File SizesView Table
Workbox Aggregate Size Plugin☠️ WARNING ☠️We are using 150% of our max size budget. Total Size: 22.03KB Gzipped: 8.77KB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @addyosmani @gauntface
Fairly straightforward port of the
workbox-range-requestscode from v2, with some test changes to accommodate the mocked interfaces, and some additional error messages.I updated the
workbox-swmapping, but I might be missing some other "meta" things that need to be changed when we add a new library.