-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding navigation route test #1126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the couple of stale strings.
const expect = require('chai').expect; | ||
const seleniumAssistant = require('selenium-assistant'); | ||
|
||
describe(`[workbox-routing] Route via RegExp`, function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"RegExp" => "NavigationRoute"
<head> | ||
</head> | ||
<body> | ||
<h1>Workbox Routing - routing-regex</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"regex" => "navigation"
PR-Bot Size PluginChanged File SizesNo file sizes have changed. New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size Plugin☠️ WARNING ☠️We are using 152% of our max size budget. Total Size: 22.25KB Gzipped: 8.85KB |
R: @jeffposnick
Adds an integration test for NavigationRoute.