Precaching idb fix #1139
Merged
Precaching idb fix #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipwalton
approved these changes
Dec 15, 2017
There was a problem hiding this comment.
LGTM, if/when we have multiple version upgrade paths in the future, I like the technique Jake suggests in the upgrading section his idb readme using switch statements with fall-through.
jeffposnick
reviewed
Dec 15, 2017
There was a problem hiding this comment.
This generally seems fine (and I trust Phil's LGTM more than mine), but there is a Travis failure in the [workbox-precaching] Precache and Update end to end test.
Since you are changing the precaching code, can you confirm whether that's a false positive or a real issue?
|
So I fixed the integration tests, but the underlyinig indexedDB mock isn't correct, so I've raised a PR against phil's version of the repo here: philipwalton/shelving-mock-indexeddb#1 |
added 2 commits
December 15, 2017 17:39
PR-Bot Size PluginChanged File Sizes
New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size Plugin☠️ WARNING ☠️We are using 151% of our max size budget. Total Size: 22.07KB Gzipped: 8.81KB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @jeffposnick @philipwalton
More changes to ensure idb works.
In IndexedDB version 1, we used two object stores 'workbox-precaching' and 'precaching-details-models'. In IndexedDB version 2 we only use 'precaching-details-models'. To ensure we are upgrading to a clean working state, this PR removes any old object stores and creates a new one.