Call new on the corresponding Plugin class. #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffposnick
commented
Jan 22, 2018
| @@ -436,10 +435,10 @@ describe(`[workbox-build] entry-points/generate-sw-string.js (End to End)`, func | |||
| await validateServiceWorkerRuntime({swCode, expectedMethodCalls: { | |||
| [STRING_HANDLER]: [[{ | |||
| cacheName: firstRuntimeCachingOptions.cacheName, | |||
| plugins: ['workbox.expiration.Plugin'], | |||
| plugins: [{}], | |||
There was a problem hiding this comment.
FYI regarding this change: we previously had a hardcoded string returned by the stubbed plugin methods in the mock environment used to make this sort of test easier to write.
Now that we're using actual classes instead of stubbed methods (to ensure that new is being called), the return value looks like a generic object. We get the same test coverage by virtue of testing the cacheableResponsePlugin and cacheExpirationPlugin spies on the following lines, though.
PR-Bot Size PluginChanged File SizesNo file sizes have changed. New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size Plugin☠️ WARNING ☠️We are using 154% of our max size budget. Total Size: 22.53KB Gzipped: 9.02KB |
gauntface
approved these changes
Jan 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @addyosmani @gauntface
CC: @mischnic
Fixes #1215
The missing
newwas an oversight during the migration to using theplugins: []property for configuring all strategy classes.