adding bg-sync tag name check #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipwalton
approved these changes
Feb 5, 2018
gauntface
reviewed
Feb 6, 2018
| @@ -94,6 +94,8 @@ class Queue { | |||
| await this._runCallback('requestWillEnqueue', storableRequest); | |||
| await this._queueStore.addEntry(storableRequest); | |||
| await this._registerSync(); | |||
| logger.log(`Request for '${request.url}' has been added to | |||
There was a problem hiding this comment.
please wrap this in an if statement for if (process.env.NODE_ENV !== 'production'){ ...log.... } This allows rollup to remove the code in prod builds.
gauntface
reviewed
Feb 6, 2018
| @@ -168,7 +170,9 @@ class Queue { | |||
| _addSyncListener() { | |||
| if ('sync' in registration) { | |||
| self.addEventListener('sync', (event) => { | |||
| event.waitUntil(this.replayRequests()); | |||
| if (event.tag === `${TAG_PREFIX}:${this._name}`) { | |||
| event.waitUntil(this.replayRequests()); | |||
There was a problem hiding this comment.
Can you add a log here to signal the sync event was received and replaying is being started.
PR-Bot Size PluginChanged File Sizes
New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size Plugin☠️ WARNING ☠️We are using 154% of our max size budget. Total Size: 22.52KB Gzipped: 9.01KB |
gauntface
approved these changes
Feb 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @jeffposnick @addyosmani @gauntface
Adds a check for tag name before replaying the requests in background sync queue.