Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set credentials: 'same-origin' on the precaching requests. #1293

Merged
merged 1 commit into from
Feb 13, 2018

Conversation

jeffposnick
Copy link
Contributor

R: @addyosmani @gauntface
CC: @mnquintana

Fixes #1288

Rather than passing in {credentials: 'same-origin'} when calling fetch(), it seemed a bit more self-contained to explicitly set the credentials property on the underlying Request object that the precaching code uses.

@workbox-pr-bot
Copy link
Collaborator

PR-Bot Size Plugin

Changed File Sizes

File Before After Change GZipped
packages/workbox-precaching/build/workbox-precaching.prod.js 5.18 KB 5.24 KB +1% 2.04 KB

New Files

No new files have been added.

All File Sizes

View Table
File Before After Change GZipped
packages/workbox-background-sync/build/workbox-background-sync.prod.js 3.27 KB 3.27 KB 0% 1.39 KB
packages/workbox-broadcast-cache-update/build/workbox-broadcast-cache-update.prod.js 1.07 KB 1.07 KB 0% 573 B
packages/workbox-build/build/_types.js 41 B 41 B 0% 61 B
packages/workbox-build/build/index.js 2.52 KB 2.52 KB 0% 1.06 KB
packages/workbox-cache-expiration/build/workbox-cache-expiration.prod.js 3.41 KB 3.41 KB 0% 1.26 KB
packages/workbox-cacheable-response/build/workbox-cacheable-response.prod.js 594 B 594 B 0% 350 B
packages/workbox-cli/build/app.js 5.09 KB 5.09 KB 0% 1.86 KB
packages/workbox-cli/build/bin.js 2.32 KB 2.32 KB 0% 1.03 KB
packages/workbox-core/build/workbox-core.prod.js 6.40 KB 6.40 KB 0% 2.54 KB
packages/workbox-google-analytics/build/workbox-google-analytics.prod.js 2.07 KB 2.07 KB 0% 1.02 KB
packages/workbox-precaching/build/workbox-precaching.prod.js 5.18 KB 5.24 KB +1% 2.04 KB
packages/workbox-range-requests/build/workbox-range-requests.prod.js 1.64 KB 1.64 KB 0% 807 B
packages/workbox-routing/build/workbox-routing.prod.js 2.77 KB 2.77 KB 0% 1.25 KB
packages/workbox-strategies/build/workbox-strategies.prod.js 3.24 KB 3.24 KB 0% 1.01 KB
packages/workbox-sw/build/workbox-sw.js 1.46 KB 1.46 KB 0% 793 B
packages/workbox-webpack-plugin/build/generate-sw.js 6.41 KB 6.41 KB 0% 2.17 KB
packages/workbox-webpack-plugin/build/index.js 742 B 742 B 0% 470 B
packages/workbox-webpack-plugin/build/inject-manifest.js 8.48 KB 8.48 KB 0% 2.77 KB

Workbox Aggregate Size Plugin

☠️ WARNING ☠️

We are using 154% of our max size budget.

Total Size: 22.57KB
Percentage of Size Used: 154%

Gzipped: 9.04KB

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.15% when pulling 003bcfe on same-origin-credentials into 50fab16 on v3.

@gauntface gauntface merged commit de2205b into v3 Feb 13, 2018
@gauntface gauntface deleted the same-origin-credentials branch February 13, 2018 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants