Log warning for bad cache control #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauntface
added
the
Chillin'
|
Chillin till I can checkout the size growth (This should only be a dev feature). |
gauntface
force-pushed
the
log-cache-control
branch
from
43f350e to
dd94124
Compare
gauntface
removed
the
Chillin'
|
@jeffposnick a review would be appreciated - I figured out how to make rollup not include this stuff. |
addyosmani
approved these changes
Feb 17, 2018
jeffposnick
reviewed
Feb 19, 2018
packages/workbox-core/_default.mjs
Outdated
| @@ -61,6 +62,8 @@ class WorkboxCore { | |||
| `${padding}https://github.com/GoogleChrome/workbox/issues/new` | |||
| ); | |||
| logger.groupEnd(); | |||
|
|
|||
| checkSWFileCacheHeaders(); | |||
There was a problem hiding this comment.
Small nit: could you wrap this in
if (typeof checkSWFileCacheHeaders === 'function') {
checkSWFileCacheHeaders();
}just to double-check that we're not somehow in a scenario in which it's set to null? I can't really imagine why that would happen with our normal builds, since this is in a NODE_ENV !== 'production' block , but I wonder if some custom build scenarios might end up leading to a mismatch.
|
@jeffposnick it shouldn't ever happen (It's following the same approach as assert class - but I added in the check regardless) |
jeffposnick
approved these changes
Feb 21, 2018
PR-Bot Size PluginChanged File SizesNo file sizes have changed. New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size Plugin☠️ WARNING ☠️We are using 155% of our max size budget. Total Size: 22.7KB Gzipped: 9.1KB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @jeffposnick @addyosmani @gauntface
Fixes #620
Adds a basic test for cache-control header.