Analytics fixes #1319
Merged
Analytics fixes #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauntface
reviewed
Feb 16, 2018
| @@ -124,6 +124,10 @@ class Queue { | |||
|
|
|||
| let storableRequest; | |||
| while (storableRequest = await this._queueStore.getAndRemoveOldestEntry()) { | |||
| // Make a copy so the unmodified request can be stored] | |||
PR-Bot Size PluginChanged File Sizes
New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size Plugin☠️ WARNING ☠️We are using 155% of our max size budget. Total Size: 22.7KB Gzipped: 9.1KB |
|
@philipwalton @gauntface working for me now 👍 Thanks guys |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @jeffposnick @addyosmani @gauntface
Fixes #1309
This PR fixes the error in #1309, which was resulting from
workbox-google-analyticssetting the replayed request headers as the string'[["Content-Type", "text/plain"]]'instead of the object.This likely means none of the replays were working, something that ideally should have been caught by an integration test. I'll put together another PR to make sure an integration test exists that ensures the entire process works. (Note, the node tests didn't catch this because we use header mock that didn't error here when they should have. Not sure if anything should be done about that though.)
In the process of manually testing it, I noticed a few other issues that I fixed as well.
workbox-background-syncrequests that were modified were storing the modified versions, I updated it to store the original.workbox-google-analyticsrequests that already included aqtparam were having that param overridden when the correct behavior should be to update it instead./cc: @DavidScales