Adds non-fatal warnings to the build tools #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauntface
approved these changes
Feb 22, 2018
| * }; | ||
| * | ||
| * @callback ManifestTransform | ||
| * @param {Array<ManifestEntry>} manifestEntries The full array of entries, | ||
| * prior to the current transformation. | ||
| * @return {Array<ManifestEntry>} The array of entries with the transformation | ||
| * applied. | ||
| * @return {{manifest: Array<ManifestEntry>, warnings: Array<String>}} |
There was a problem hiding this comment.
Make the warnings optional to return.
| }); | ||
|
|
||
| return entry; | ||
| }); | ||
| return {manifest, warnings: []}; |
| return entry; | ||
| }); | ||
|
|
||
| return {manifest, warnings: []}; |
|
I'm happy that we're returning the E.g., we handle errors from modules in our own first-party |
PR-Bot Size PluginChanged File Sizes
New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size Plugin☠️ WARNING ☠️We are using 155% of our max size budget. Total Size: 22.7KB Gzipped: 9.1KB |
|
@jeffposnick thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @addyosmani @gauntface
Fixes #1315, fixes #1176
This adds in support for non-fatal warnings in
workbox-build, as well as reporting those errors back to the developers viaworkbox-clianworkbox-webpack-plugin.Two classes of problems are treated as warnings now:
maximumFileSizeToCacheInBytes