-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new workboxSWImport option to the template. #1327
Conversation
if (workboxSWImports) { | ||
// Get the Workbox SW import from the first element in the array. | ||
workboxSWImport = workboxSWImports.shift(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why you are shifting here. To me it feels safer to have all workboxSWImports
together, then the possible config and then the developers import scripts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I would really like for all the workbox sw imports to be grouped together but if I'm missing something or actually you strongly disagree, then I'm still happy :)
PR-Bot Size PluginChanged File Sizes
New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size Plugin☠️ WARNING ☠️We are using 155% of our max size budget. Total Size: 22.7KB Gzipped: 9.1KB |
The only weird case is when someone uses |
R: @addyosmani @gauntface
CC: @beatrizdemiguelperez
Fixes #1324
Should hopefully be a clean fix to the issue.