Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new workboxSWImport option to the template. #1327

Merged
merged 2 commits into from
Feb 22, 2018
Merged

Conversation

jeffposnick
Copy link
Contributor

R: @addyosmani @gauntface
CC: @beatrizdemiguelperez

Fixes #1324

Should hopefully be a clean fix to the issue.

@coveralls
Copy link

coveralls commented Feb 21, 2018

Coverage Status

Coverage increased (+0.05%) to 88.269% when pulling 27d80a5 on workbox-sw-import into aee6b98 on v3.

if (workboxSWImports) {
// Get the Workbox SW import from the first element in the array.
workboxSWImport = workboxSWImports.shift();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why you are shifting here. To me it feels safer to have all workboxSWImports together, then the possible config and then the developers import scripts.

Copy link

@gauntface gauntface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I would really like for all the workbox sw imports to be grouped together but if I'm missing something or actually you strongly disagree, then I'm still happy :)

@workbox-pr-bot
Copy link
Collaborator

PR-Bot Size Plugin

Changed File Sizes

File Before After Change GZipped
packages/workbox-webpack-plugin/build/generate-sw.js 6.41 KB 7.21 KB +13% 2.40 KB ☠️

New Files

No new files have been added.

All File Sizes

View Table
File Before After Change GZipped
packages/workbox-background-sync/build/workbox-background-sync.prod.js 3.52 KB 3.52 KB 0% 1.45 KB
packages/workbox-broadcast-cache-update/build/workbox-broadcast-cache-update.prod.js 1.07 KB 1.07 KB 0% 573 B
packages/workbox-build/build/_types.js 41 B 41 B 0% 61 B
packages/workbox-build/build/index.js 2.52 KB 2.52 KB 0% 1.06 KB
packages/workbox-cache-expiration/build/workbox-cache-expiration.prod.js 3.41 KB 3.41 KB 0% 1.26 KB
packages/workbox-cacheable-response/build/workbox-cacheable-response.prod.js 594 B 594 B 0% 350 B
packages/workbox-cli/build/app.js 5.09 KB 5.09 KB 0% 1.86 KB
packages/workbox-cli/build/bin.js 2.32 KB 2.32 KB 0% 1.03 KB
packages/workbox-core/build/workbox-core.prod.js 6.48 KB 6.48 KB 0% 2.59 KB
packages/workbox-google-analytics/build/workbox-google-analytics.prod.js 2.12 KB 2.12 KB 0% 1.05 KB
packages/workbox-precaching/build/workbox-precaching.prod.js 5.26 KB 5.26 KB 0% 2.06 KB
packages/workbox-range-requests/build/workbox-range-requests.prod.js 1.64 KB 1.64 KB 0% 807 B
packages/workbox-routing/build/workbox-routing.prod.js 2.77 KB 2.77 KB 0% 1.25 KB
packages/workbox-strategies/build/workbox-strategies.prod.js 3.26 KB 3.26 KB 0% 1.02 KB
packages/workbox-sw/build/workbox-sw.js 1.46 KB 1.46 KB 0% 793 B
packages/workbox-webpack-plugin/build/generate-sw.js 6.41 KB 7.21 KB +13% 2.40 KB ☠️
packages/workbox-webpack-plugin/build/index.js 742 B 742 B 0% 470 B
packages/workbox-webpack-plugin/build/inject-manifest.js 8.82 KB 8.82 KB 0% 2.89 KB

Workbox Aggregate Size Plugin

☠️ WARNING ☠️

We are using 155% of our max size budget.

Total Size: 22.7KB
Percentage of Size Used: 155%

Gzipped: 9.1KB

@jeffposnick
Copy link
Contributor Author

The only weird case is when someone uses importWorkboxFrom: <chunkname> and that chunk contains multiple JavaScript assets. I've modified the PR to group everything together at the front of the importScripts for that specific use case. (We don't end up calling workbox.setConfig() in that scenario.)

@jeffposnick jeffposnick merged commit 1aef270 into v3 Feb 22, 2018
@jeffposnick jeffposnick deleted the workbox-sw-import branch February 22, 2018 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants