Using cache name as idb name for precaching #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-Bot Size PluginChanged File Sizes
New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size Plugin☠️ WARNING ☠️We are using 158% of our max size budget. Total Size: 23.21KB Gzipped: 9.24KB |
jeffposnick
approved these changes
Mar 6, 2018
| * @private | ||
| */ | ||
| constructor() { | ||
| this._db = new DBWrapper(`workbox-precaching`, 2, { | ||
| constructor(dbName) { |
There was a problem hiding this comment.
Just wanted to double-check: it looks like the existing codebase is already passing in a string parameter when calling this constructor, even though it was previously being ignored. So now the change is that you're using that string value inside of this constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1344