Make webpack path and filename options more customizable #1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauntface
reviewed
Mar 28, 2018
| excludeChunks: [], | ||
| importScripts: [], | ||
| importWorkboxFrom: 'cdn', | ||
| this.config = Object.assign(getDefaultConfig(), { | ||
| swDest: 'service-worker.js', |
There was a problem hiding this comment.
Can you add a comment to both plugins calling out why this is seperate.
gauntface
approved these changes
Mar 28, 2018
PR-Bot Size PluginChanged File Sizes
New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size Plugin☠️ WARNING ☠️We are using 159% of our max size budget. Total Size: 23.3KB Gzipped: 9.25KB |
This was referenced Mar 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @addyosmani @gauntface
CC: @raejin
Fixes #1285
This adds the following to both the
InjectManifestandGenerateSWwebpack plugins:An optional
precacheManifestFilenameparameter, defaulting to'precache-manifest.[manifestHash].js'(i.e. the current behavior). It can be used to customize the precache manifest name. If the string'[manifestHash]'isn't included in your custom name, that's treated as a webpack compilation error.An optional
importsDirectoryparameter, defaulting to''(i.e. the current behavior). It is treated as a subdirectory ofoutput.path. When set, the precache manifest is written to this directory, and ifimportWorkboxFrom: 'local', the local Workbox libraries are written there as well.Automatic adjustments to the URLs used in
importScripts()to account for both of these potential customizations.When
importWorkboxFrom: 'local'andoutput.publicPathis configured, theoutput.publicPathvalue will be prepended to themodulePathPrefixused to determine where the Workbox libraries are dynamically loaded from. This amounts to a change in the previous behavior, but based on developer expectation, the previous behavior was considered a bug.There needs to be a corresponding update to the WebFundamentals docs once this is merged.