Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds makeRequest() method to workbox.strategies #1408

Merged
merged 2 commits into from
Apr 6, 2018

Conversation

jeffposnick
Copy link
Contributor

R: @gauntface @philipwalton

Fixes #1395

This allows any of the workbox.strategies.* classes to be called manually, outside of a Route context.

The JSDocs in this PR refer to https://developers.google.com/web/tools/workbox/guides/advanced-recipes#make-requests, which I'll write following this PR.

@gauntface
Copy link

Is there any value in keeping the handle() method with this change?

@jeffposnick
Copy link
Contributor Author

Removing .handle() entirely would be a breaking change to the interface. While I doubt there are too many folks calling .handle() directly, we'd have to make some changes to the workbox-routing to go along with removing .handle(), and that might be more likely to break existing assumptions.

So I'd rather punt on that until the next round of discussions about breaking interface changes.

@jeffposnick jeffposnick merged commit 482814f into master Apr 6, 2018
@jeffposnick jeffposnick deleted the strategies-make-request branch April 6, 2018 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants