Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swSrc to list of file dependencies for InjectManifest #1432

Merged

Conversation

green-arrow
Copy link
Contributor

R: @jeffposnick @addyosmani @gauntface

Fixes #1428

Description of what's changed/fixed.

Currently, webpack won't rebuild when in watch mode if a custom service worker swSrc is modified. This PR adds the custom service worker to the list of watched files according to this part of the webpack docs.

I looked through the tests for inject-manifest, but I'm not entirely sure how to write a proper test that validates the functionality. I'm happy to add a test if someone can point me in the right direction!

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@green-arrow green-arrow force-pushed the webpack-watch-custom-sw branch from 628a0d4 to af0ffff Compare April 13, 2018 20:38
@green-arrow
Copy link
Contributor Author

@googlebot - I signed it

@googlebot
Copy link

CLAs look good, thanks!

@jeffposnick jeffposnick self-requested a review April 18, 2018 19:46
@jeffposnick
Copy link
Contributor

Thanks, @green-arrow! This looks like the right approach.

(I'll kick the AppVeyor CI test to see why it's failing, but it doesn't look like it's related to your PR.)

@jeffposnick jeffposnick merged commit d3e3a88 into GoogleChrome:master Apr 19, 2018
@green-arrow
Copy link
Contributor Author

Glad to see this make it in, thanks @jeffposnick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webpack doesn't rebuild when using InjectManifest with a custom service worker
3 participants