Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional try/catch blocks around async waitUntil calls #1457

Merged
merged 1 commit into from
May 1, 2018

Conversation

jeffposnick
Copy link
Contributor

R: @philipwalton

Fixes #1435

This is analogous to the change in #1392. I've gone through all the other strategies that might call event.waitUntil() asynchronously, and added the same change there.

@jeffposnick jeffposnick requested a review from philipwalton May 1, 2018 15:29
@workbox-pr-bot
Copy link
Collaborator

PR-Bot Size Plugin

Changed File Sizes

No file sizes have changed.

New Files

File Size GZipped
packages/workbox-background-sync/build/workbox-background-sync.prod.js 3.51 KB 1.45 KB
packages/workbox-broadcast-cache-update/build/workbox-broadcast-cache-update.prod.js 1.12 KB 584 B
packages/workbox-build/build/_types.js 41 B 61 B
packages/workbox-build/build/index.js 4.02 KB 1.57 KB
packages/workbox-cache-expiration/build/workbox-cache-expiration.prod.js 3.41 KB 1.26 KB
packages/workbox-cacheable-response/build/workbox-cacheable-response.prod.js 587 B 345 B
packages/workbox-cli/build/app.js 6.50 KB 2.16 KB
packages/workbox-cli/build/bin.js 2.32 KB 1.03 KB
packages/workbox-core/build/workbox-core.prod.js 6.53 KB 2.66 KB
packages/workbox-google-analytics/build/workbox-google-analytics.prod.js 2.12 KB 1.03 KB
packages/workbox-precaching/build/workbox-precaching.prod.js 5.68 KB 2.16 KB
packages/workbox-range-requests/build/workbox-range-requests.prod.js 1.63 KB 797 B
packages/workbox-routing/build/workbox-routing.prod.js 2.75 KB 1.24 KB
packages/workbox-strategies/build/workbox-strategies.prod.js 4.30 KB 1.14 KB
packages/workbox-streams/build/workbox-streams.prod.js 1.60 KB 732 B
packages/workbox-sw/build/workbox-sw.js 1.47 KB 791 B
packages/workbox-webpack-plugin/build/generate-sw.js 8.04 KB 2.57 KB
packages/workbox-webpack-plugin/build/index.js 742 B 470 B
packages/workbox-webpack-plugin/build/inject-manifest.js 9.67 KB 3.07 KB

All File Sizes

View Table
File Before After Change GZipped
packages/workbox-background-sync/build/workbox-background-sync.prod.js 3.51 KB 1.45 KB
packages/workbox-broadcast-cache-update/build/workbox-broadcast-cache-update.prod.js 1.12 KB 584 B
packages/workbox-build/build/_types.js 41 B 61 B
packages/workbox-build/build/index.js 4.02 KB 1.57 KB
packages/workbox-cache-expiration/build/workbox-cache-expiration.prod.js 3.41 KB 1.26 KB
packages/workbox-cacheable-response/build/workbox-cacheable-response.prod.js 587 B 345 B
packages/workbox-cli/build/app.js 6.50 KB 2.16 KB
packages/workbox-cli/build/bin.js 2.32 KB 1.03 KB
packages/workbox-core/build/workbox-core.prod.js 6.53 KB 2.66 KB
packages/workbox-google-analytics/build/workbox-google-analytics.prod.js 2.12 KB 1.03 KB
packages/workbox-precaching/build/workbox-precaching.prod.js 5.68 KB 2.16 KB
packages/workbox-range-requests/build/workbox-range-requests.prod.js 1.63 KB 797 B
packages/workbox-routing/build/workbox-routing.prod.js 2.75 KB 1.24 KB
packages/workbox-strategies/build/workbox-strategies.prod.js 4.30 KB 1.14 KB
packages/workbox-streams/build/workbox-streams.prod.js 1.60 KB 732 B
packages/workbox-sw/build/workbox-sw.js 1.47 KB 791 B
packages/workbox-webpack-plugin/build/generate-sw.js 8.04 KB 2.57 KB
packages/workbox-webpack-plugin/build/index.js 742 B 470 B
packages/workbox-webpack-plugin/build/inject-manifest.js 9.67 KB 3.07 KB

Workbox Aggregate Size Plugin

☠️ WARNING ☠️

We are using 165% of our max size budget.

Total Size: 24.14KB
Percentage of Size Used: 165%

Gzipped: 9.38KB

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 87.057% when pulling f3de7c8 on async-waituntil-fixes into 77b64a7 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants