Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to network if there's a cache miss for registerNavigationRoute #1460

Merged
merged 1 commit into from
May 1, 2018

Conversation

jeffposnick
Copy link
Contributor

FYI: @philipwalton
CC: @coryrylan

This provides a fallback for the scenario mentioned in #1441, but I'd like to leave that issue open to track the underlying cause.

This is the equivalent of the previously approached #1300, in a fresh PR against the current master branch.

@workbox-pr-bot
Copy link
Collaborator

PR-Bot Size Plugin

Changed File Sizes

No file sizes have changed.

New Files

File Size GZipped
packages/workbox-background-sync/build/workbox-background-sync.prod.js 3.51 KB 1.45 KB
packages/workbox-broadcast-cache-update/build/workbox-broadcast-cache-update.prod.js 1.12 KB 584 B
packages/workbox-build/build/_types.js 41 B 61 B
packages/workbox-build/build/index.js 4.02 KB 1.57 KB
packages/workbox-cache-expiration/build/workbox-cache-expiration.prod.js 3.41 KB 1.26 KB
packages/workbox-cacheable-response/build/workbox-cacheable-response.prod.js 587 B 345 B
packages/workbox-cli/build/app.js 6.50 KB 2.16 KB
packages/workbox-cli/build/bin.js 2.32 KB 1.03 KB
packages/workbox-core/build/workbox-core.prod.js 6.53 KB 2.66 KB
packages/workbox-google-analytics/build/workbox-google-analytics.prod.js 2.12 KB 1.03 KB
packages/workbox-precaching/build/workbox-precaching.prod.js 5.68 KB 2.16 KB
packages/workbox-range-requests/build/workbox-range-requests.prod.js 1.63 KB 797 B
packages/workbox-routing/build/workbox-routing.prod.js 2.87 KB 1.30 KB
packages/workbox-strategies/build/workbox-strategies.prod.js 4.30 KB 1.14 KB
packages/workbox-streams/build/workbox-streams.prod.js 1.60 KB 732 B
packages/workbox-sw/build/workbox-sw.js 1.47 KB 791 B
packages/workbox-webpack-plugin/build/generate-sw.js 8.04 KB 2.57 KB
packages/workbox-webpack-plugin/build/index.js 742 B 470 B
packages/workbox-webpack-plugin/build/inject-manifest.js 9.67 KB 3.07 KB

All File Sizes

View Table
File Before After Change GZipped
packages/workbox-background-sync/build/workbox-background-sync.prod.js 3.51 KB 1.45 KB
packages/workbox-broadcast-cache-update/build/workbox-broadcast-cache-update.prod.js 1.12 KB 584 B
packages/workbox-build/build/_types.js 41 B 61 B
packages/workbox-build/build/index.js 4.02 KB 1.57 KB
packages/workbox-cache-expiration/build/workbox-cache-expiration.prod.js 3.41 KB 1.26 KB
packages/workbox-cacheable-response/build/workbox-cacheable-response.prod.js 587 B 345 B
packages/workbox-cli/build/app.js 6.50 KB 2.16 KB
packages/workbox-cli/build/bin.js 2.32 KB 1.03 KB
packages/workbox-core/build/workbox-core.prod.js 6.53 KB 2.66 KB
packages/workbox-google-analytics/build/workbox-google-analytics.prod.js 2.12 KB 1.03 KB
packages/workbox-precaching/build/workbox-precaching.prod.js 5.68 KB 2.16 KB
packages/workbox-range-requests/build/workbox-range-requests.prod.js 1.63 KB 797 B
packages/workbox-routing/build/workbox-routing.prod.js 2.87 KB 1.30 KB
packages/workbox-strategies/build/workbox-strategies.prod.js 4.30 KB 1.14 KB
packages/workbox-streams/build/workbox-streams.prod.js 1.60 KB 732 B
packages/workbox-sw/build/workbox-sw.js 1.47 KB 791 B
packages/workbox-webpack-plugin/build/generate-sw.js 8.04 KB 2.57 KB
packages/workbox-webpack-plugin/build/index.js 742 B 470 B
packages/workbox-webpack-plugin/build/inject-manifest.js 9.67 KB 3.07 KB

Workbox Aggregate Size Plugin

☠️ WARNING ☠️

We are using 166% of our max size budget.

Total Size: 24.25KB
Percentage of Size Used: 166%

Gzipped: 9.44KB

@philipwalton
Copy link
Member

SGTM

@jeffposnick jeffposnick merged commit c171428 into master May 1, 2018
@jeffposnick jeffposnick deleted the navigation-route-fetch-fallback branch May 1, 2018 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants