-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the code that swaps 'prod' for 'dev' in copyWorkboxLibraries #1488
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one minor grammar error.
expect(result).to.eql('/path/to/production/also.prod.path/workbox.dev.js'); | ||
}); | ||
|
||
it(`should not update anything is there is no match for the default build type`, function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the first "is" to "if".
PR-Bot Size PluginChanged File SizesNo file sizes have changed. New Files
All File SizesView Table
Workbox Aggregate Size Plugin☠️ WARNING ☠️We are using 166% of our max size budget. Total Size: 24.26KB Gzipped: 9.44KB |
R: @philipwalton
Fixes #1478
This code path is still a bit hacky, and there's a lot of hardcoded assumptions, but at least it should now work as expected when the
source
path contains multiple instances ofDEFAULT_BUILD_TYPE
.