Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the code that swaps 'prod' for 'dev' in copyWorkboxLibraries #1488

Merged
merged 5 commits into from
May 18, 2018

Conversation

jeffposnick
Copy link
Contributor

R: @philipwalton

Fixes #1478

This code path is still a bit hacky, and there's a lot of hardcoded assumptions, but at least it should now work as expected when the source path contains multiple instances of DEFAULT_BUILD_TYPE.

@jeffposnick jeffposnick requested a review from philipwalton May 18, 2018 17:11
Copy link
Member

@philipwalton philipwalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor grammar error.

expect(result).to.eql('/path/to/production/also.prod.path/workbox.dev.js');
});

it(`should not update anything is there is no match for the default build type`, function() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the first "is" to "if".

@workbox-pr-bot
Copy link
Collaborator

PR-Bot Size Plugin

Changed File Sizes

No file sizes have changed.

New Files

File Size GZipped
packages/workbox-background-sync/build/workbox-background-sync.prod.js 3.51 KB 1.45 KB
packages/workbox-broadcast-cache-update/build/workbox-broadcast-cache-update.prod.js 1.12 KB 584 B
packages/workbox-build/build/_types.js 41 B 61 B
packages/workbox-build/build/index.js 4.02 KB 1.57 KB
packages/workbox-cache-expiration/build/workbox-cache-expiration.prod.js 3.41 KB 1.26 KB
packages/workbox-cacheable-response/build/workbox-cacheable-response.prod.js 587 B 345 B
packages/workbox-cli/build/app.js 6.50 KB 2.16 KB
packages/workbox-cli/build/bin.js 2.32 KB 1.03 KB
packages/workbox-core/build/workbox-core.prod.js 6.54 KB 2.66 KB
packages/workbox-google-analytics/build/workbox-google-analytics.prod.js 2.12 KB 1.03 KB
packages/workbox-precaching/build/workbox-precaching.prod.js 5.68 KB 2.16 KB
packages/workbox-range-requests/build/workbox-range-requests.prod.js 1.63 KB 797 B
packages/workbox-routing/build/workbox-routing.prod.js 2.87 KB 1.31 KB
packages/workbox-strategies/build/workbox-strategies.prod.js 4.30 KB 1.14 KB
packages/workbox-streams/build/workbox-streams.prod.js 1.66 KB 765 B
packages/workbox-sw/build/workbox-sw.js 1.47 KB 792 B
packages/workbox-webpack-plugin/build/generate-sw.js 8.04 KB 2.57 KB
packages/workbox-webpack-plugin/build/index.js 742 B 470 B
packages/workbox-webpack-plugin/build/inject-manifest.js 10.30 KB 3.23 KB

All File Sizes

View Table
File Before After Change GZipped
packages/workbox-background-sync/build/workbox-background-sync.prod.js 3.51 KB 1.45 KB
packages/workbox-broadcast-cache-update/build/workbox-broadcast-cache-update.prod.js 1.12 KB 584 B
packages/workbox-build/build/_types.js 41 B 61 B
packages/workbox-build/build/index.js 4.02 KB 1.57 KB
packages/workbox-cache-expiration/build/workbox-cache-expiration.prod.js 3.41 KB 1.26 KB
packages/workbox-cacheable-response/build/workbox-cacheable-response.prod.js 587 B 345 B
packages/workbox-cli/build/app.js 6.50 KB 2.16 KB
packages/workbox-cli/build/bin.js 2.32 KB 1.03 KB
packages/workbox-core/build/workbox-core.prod.js 6.54 KB 2.66 KB
packages/workbox-google-analytics/build/workbox-google-analytics.prod.js 2.12 KB 1.03 KB
packages/workbox-precaching/build/workbox-precaching.prod.js 5.68 KB 2.16 KB
packages/workbox-range-requests/build/workbox-range-requests.prod.js 1.63 KB 797 B
packages/workbox-routing/build/workbox-routing.prod.js 2.87 KB 1.31 KB
packages/workbox-strategies/build/workbox-strategies.prod.js 4.30 KB 1.14 KB
packages/workbox-streams/build/workbox-streams.prod.js 1.66 KB 765 B
packages/workbox-sw/build/workbox-sw.js 1.47 KB 792 B
packages/workbox-webpack-plugin/build/generate-sw.js 8.04 KB 2.57 KB
packages/workbox-webpack-plugin/build/index.js 742 B 470 B
packages/workbox-webpack-plugin/build/inject-manifest.js 10.30 KB 3.23 KB

Workbox Aggregate Size Plugin

☠️ WARNING ☠️

We are using 166% of our max size budget.

Total Size: 24.26KB
Percentage of Size Used: 166%

Gzipped: 9.44KB

@jeffposnick jeffposnick merged commit 90883e6 into master May 18, 2018
@jeffposnick jeffposnick deleted the better-use-build-type branch May 18, 2018 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants