Add support for fetchOptions/matchOptions in runtimeCachingConverter #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffposnick
approved these changes
Aug 22, 2018
There was a problem hiding this comment.
Thanks so much for this @peterjosling (and thanks in particular for writing tests)! The code looks good, and playing around with the change locally indicates that everything works as expected.
We're looking at the next minor release some time in the first half of September, and I think this change should make it into that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @jeffposnick @philipwalton
Fixes #1607
Caching strategies support taking objects for
fetchOptionsandmatchOptions, butruntimeCachingConverterhas no support for taking them as input.I've left both as
joi.object()in the schema, as I'm not sure how to specify a DOM interface as the type/if it's possible, and I don't think it makes sense to duplicate browser specs in the schema.