[ON HOLD] workbox-cli dependencies updates #1609
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffposnick
added
the
Chillin'
philipwalton
approved these changes
Aug 20, 2018
|
Closing in favor of #1658 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Do not merge yet, as this breaks node v4 compatibility. We'll need to time this with a major semver release.]
R: @philipwalton
Fixes #1542, fixes #1574
This bumps a few dependencies used by the
workbox-clipackage.I was able to put together a basic standalone reproduction of the Windows problems using the previous versions of both
inquirerandfs-extra, and can confirm that after this update, it works as expected. I'm not 100% sure whether it's the change toinquireror the change tofs-extrathat resolved things, but updating everything seemed prudent.