Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method option to GenerateSW validation #1638

Merged
merged 2 commits into from
Sep 18, 2018

Conversation

chrisdns
Copy link
Contributor

@chrisdns chrisdns commented Sep 17, 2018

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@chrisdns
Copy link
Contributor Author

I signed it 👍

@googlebot
Copy link

CLAs look good, thanks!

@jeffposnick
Copy link
Contributor

Would you mind adding in validation while we're at it, to match

export const validMethods = [
'DELETE',
'GET',
'HEAD',
'PATCH',
'POST',
'PUT',
];

It could be something like

method: joi.string().valid(
  'DELETE',
  'GET',
  '...',
),

Copy link
Contributor

@jeffposnick jeffposnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@jeffposnick jeffposnick merged commit 02cc85b into GoogleChrome:master Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants