Add a UMD build for workbox-window #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-Bot Size PluginChanged File Sizes
New Files
All File SizesView Table
Workbox Aggregate Size Plugin8.78KB gzip'ed (59% of limit) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @jeffposnick
Fixes #1894
This PR updates the Rollup build steps to use the regular Rollup API instead of the gulp rollup stream approach. It also updates
workbox-windowto output a UMD build in addition to an ES module build, soworkbox-windowcan berequired()in popular application frameworks that server-side render code in node.I think this change may also fix some other issues that were previously untested, since adding the UMD builds caused a lot of tests to fail that we're previously not failing, perhaps due to the
workbox-windowonly having.mjsinstead of.jsfiles.