Resolve getSW correctly after an update is found #1941
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @jeffposnick
Fixes #1939
The previous workbox-window logic would created a deferred for the instances "own" service worker and, once resolved, always return that service worker in the
getSW()
(and consequently themessageSW()
method). But in the case of a SW already controlling the page and then an update being found for the same URL, this wouldn't be the desired behavior.This PR updates the logic to handle this case.
/cc @Avocher