Convert source to Buffer when getting asset's hash #1966
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @jeffposnick @philipwalton
Fixes #1916
Description of what's changed/fixed.
asset.source()
will return string or ArrayBuffer (Ref.) (or Buffer via some loaders), butHash.update()
shouldnot receive ArrayBuffer (Ref.).Because of that, this PR enables to convert source to Buffer when getting asset's hash.