-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the sw imports sorted #1973
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
We unfortunately need to update the hashes hardcoded in the unit tests when there's a change that alters the webpack plugin's output. I'll push a commit to the branch in this PR with the necessary updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Thanks for handling the tests. Can you publish a new version to npm? (We have a package layout file that lists all the files and this makes precache file change the name randomly) |
Likely within the next week or so—we do try to batch up the changes a bit in between releases. |
Ohh, that works thanks. I will just disable the chunks until then ;) |
R: @jeffposnick @philipwalton
Fixes #1972
Description of what's changed/fixed.
Added sorting before generating a hash