Adds cacheKeyWillBeUsed lifecycle callback #1990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipwalton
requested changes
Mar 28, 2019
| @@ -366,5 +443,78 @@ describe(`cacheWrapper`, function() { | |||
| expect(spyOne.callCount).to.equal(1); | |||
| expect(spyTwo.callCount).to.equal(1); | |||
| }); | |||
|
|
|||
| it(`should call cacheKeyWillBeUsed`, async function() { | |||
There was a problem hiding this comment.
Repeat code? Looks like these two tests are the same as the ones above.
There was a problem hiding this comment.
They're in different describe() blocks—one for .put() and the other for .match(). The actual test cases are different, too.
There was a problem hiding this comment.
In particular, the tests confirm that the correct mode value ('read' or 'write') is passed in to the plugin, and that the underlying cache.match() or cache.put() operation is actually called with the plugin's return value.
There was a problem hiding this comment.
Ahh, I see. I couldn't easily see the outer blocks from the diff.
philipwalton
approved these changes
Mar 28, 2019
PR-Bot Size PluginChanged File Sizes
New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size Plugin8.86KB gzip'ed (59% of limit) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @philipwalton
Fixes #1709
This adds a new
cacheKeyWillBeUsedlifecycle callback, following the interface described at #1709 (comment). This allows developers to override the default cache key for reads or writes (or both), for requests that pass through ourcacheWrapperinterface.Once it's released, we'll need to update https://developers.google.com/web/tools/workbox/guides/using-plugins with info on usage.