Convert workbox-navigation-preload to Typescript #2097
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @jeffposnick
This PR continues the migration to Typescript (started in #2058) and adds type definitions for
workbox-navigation-preload
. (Note: I was going in alphabetical order, but then I realizedworkbox-google-analytics
has unconverted dependencies, so I had to skip it.)This PR also updates how
self
is declared, as I realized lots of the Service Worker typings already exist, they're just not available unless you manually declareself
asServiceWorkerGlobalScore
(which is annoying).See: microsoft/TypeScript#14877 (comment)