Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch the minimum supported node version to 10 #2462

Merged
merged 2 commits into from
Apr 24, 2020
Merged

Switch the minimum supported node version to 10 #2462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e4b14a
Switch to node 10
jeffposnick Apr 21, 2020
196b8c7
Win should use Node 10
jeffposnick Apr 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,11 @@ jobs:

- uses: actions/setup-node@v1
with:
node-version: 8.x
node-version: 10.x

- name: Setup
run: |
# Use `npm i` to work around https://github.com/npm/cli/issues/558
npm i
npm ci
gulp build

- run: npx gulp test-node
Expand Down
2 changes: 1 addition & 1 deletion gulp-tasks/utils/build-node-package.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ module.exports = (packagePath) => {
['@babel/preset-env', {
targets: {
// Change this when our minimum required node version changes.
node: '8.0',
node: '10.0',
},
}],
],
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "workbox",
"engines": {
"node": ">=8.0.0"
"node": ">=10.0.0"
},
"scripts": {
"bot": "pr-bot",
Expand Down
2 changes: 1 addition & 1 deletion packages/workbox-build/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"file manifest"
],
"engines": {
"node": ">=8.0.0"
"node": ">=10.0.0"
},
"author": "Google's Web DevRel Team",
"license": "MIT",
Expand Down
2 changes: 1 addition & 1 deletion packages/workbox-cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"build"
],
"engines": {
"node": ">=8.0.0"
"node": ">=10.0.0"
},
"scripts": {
"prepublish": "gulp build-packages --package workbox-cli"
Expand Down
2 changes: 1 addition & 1 deletion packages/workbox-webpack-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"build"
],
"engines": {
"node": ">=8.0.0"
"node": ">=10.0.0"
},
"dependencies": {
"@babel/runtime": "^7.5.5",
Expand Down