Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @philipwalton @housseindjirdeh (who might have some more
webpack
background)Fixes #2630
There are unfortunately a lot of changes; they basically follow the guidance I received from the webpack team at webpack/webpack#11425
The codebase should work with webpack v4.40.0 or higher or webpack v5.0.0, so that's a breaking change (we previously worked with webpack v4.0.0 or higher).
There are now two different sets of tests, each going against a different major version of webpack. (Thanks to @developit for help getting the proper node module resolution set up.)
One major outstanding issue is compatibility with the latest
html-webpack-plugin
(see jantimon/html-webpack-plugin#1522); I believe they still need to do some work to properly support webpack v5.0.0, and in the meantime, I would consider using our plugin alongside it unsupported. I did not want that to block getting this new code out there for the Workbox v6 prereleases, though.