Updates for html-webpack-plugin and webpack v5 #2651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipwalton
approved these changes
Nov 6, 2020
This was referenced Dec 20, 2023
This was referenced Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @housseindjirdeh @Snugug @philipwalton
The
html-webpack-pluginproject recently fixed somewebpackv5 compatibility issues: jantimon/html-webpack-plugin#1522There was some code in the
v6branch that attempted to work around the previous incompatibility, as we wantworkbox-webpack-pluginto play nicely withhtml-webpack-plugin, but that can be removed now that the underlying issue with the other plugin is resolved.