Make use of AssetInfo in webpack build #2673
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @Snugug @housseindjirdeh @philipwalton
Fixes #2221, fixes #2672
Some small changes to the
workbox-webpack-plugin
to take proper advantage ofwebpack
'sAssetInfo
capabilities.When we create an asset via
GenerateSW
and we know that it's already been compressed, we now setminimized: true
.When we read assets from the build to generate our precache manifest, if any assets have
immutable: true
, that's a clear sign that we don't need to generate hashes for them, so we can returnnull
for therevision
parameter. The JSDoc fordontCacheBustURLsMatching
has also been updated to reflect this.