Update the stage at which the webpack plugin runs #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snugug
approved these changes
Nov 13, 2020
There was a problem hiding this comment.
Again, don't know much about Webpack/plugin internals, but from reading the related issue this LGTM from what I can tell.
Only question I have, and is likely because I don't know the test suite well, is if there needs to be a test for this written for generate-sw in addition to inject-manifest, but I won't block on an answer.
|
@jeffposnick told me that the test is just being moved to the correct |
This was referenced Dec 20, 2023
This was referenced Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @Snugug @philipwalton
Fixes #2670
This is a tactical fix to get compatibility back with
html-webpack-plugininwebpackv5 until webpack/webpack#11822 is resolved.