chunks/excludeChunks can match compilation.chunkNames #2735
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @developit @philipwalton @housseindjirdeh
Fixes #2717
workbox-webpack-plugin
provides a way of allow/denylisting the assets in its precache manifest based on chunk names.When making changes to the webpack plugin for the last major release, we started looking at the
compilation.namedChunkGroups
property to check for matches inchunks
/excludeChunks
. This neglects the fact that developers might also expect the names they provide to match againstcompilation.namedChunks
(i.e. the actual chunk names, not the group names).The code in this PR will still give preference to a match in
compilation.namedChunkGroups
(so it should be backwards-compatible), but for situations in which there's no match, it will fall back to checkingcompilation.namedChunks
.