[Feature] (workbox-cli) Prompt for 'ignoreURLParametersMatching' in workbox wizard #2763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 25, 2021 19:34
Extend workbox-cli with a question regarding the 'ignoreURLParametersMatching' workbox config parameter. ✅ Closes: GoogleChrome#2758
Provide assertions to workbox-cli package regarding question for 'ignoreURLParametersMatching' workbox config parameter with meaningful error messages.
Provided instances of RegExp (for ignoring the set of search parameters) should be converted to string values (using the native RegExp.prototype.toString method), as JSON.stringify is not able to convert RegExp class instances into corresponding regular expressions before writing the configuration to workbox-config.js file.
Refactor defaults for 'ignoreURLParametersMatching' config parameter into constants.
Provide tests for the query parameters in start url question (tests lib/questions/ask-start_url-query-params). Extend the lib/questions/ask-questions.js tests with newly added question. ✅ Closes: GoogleChrome#2758
jeffposnick
approved these changes
Mar 1, 2021
This was referenced Mar 15, 2021
Closed
This was referenced Mar 16, 2021
Closed
Bump workbox-build from 3.3.1 to 6.1.2 in /themes/docsy/assets/vendor/bootstrap
davidspek/website#34
Closed
This was referenced Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2758
R: @jeffposnick @philipwalton
Changes
Checklist
After the changes I ensured that:
gulp lintandgulp lint testfrom the root directory,gulp testfrom the root directory,gulp buildfrom the root directory,mkdir workbox-test && cd workbox-test && npm init -y,npm i ~/path/to/workbox/projects/workbox/packages/workbox-cli && ./node_modules/.bin/workbox wizard,workbox-config.jsfile content.Done