Fire controlling event more than once (#2817)

[rockwalrus]

R: @jeffposnick @tropicadri

Fixes #2817

Description of what's changed/fixed.
Dispatches the controlling event every time the documentation specifies that it should.

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[rockwalrus]

My employer, State Farm, has signed a CLA. Can you tell me who the point of contact is to be added to the list of people authorized to contribute?

[tropicadri]

@rockwalrus I just want to confirm that you are using your State Farm email to create the commit?

[jeffposnick]

Just as an FYI, we're bundling up a few "ideally not breaking, but let's be careful and try them out first" changes into an upcoming 6.2.0-alpha.0 release. This PR will fall into that bucket, as it fixes what's arguably a bug, we also want to make sure we give folks a chance to test out this updated behavior and ensure it doesn't break their existing assumptions.

We haven't forgotten about the PR, but are wrapping up a few other changes first. Thanks!

[rockwalrus]

@rockwalrus I just want to confirm that you are using your State Farm email to create the commit?

Yes, I am using my State Farm email for the commit.

[jeffposnick]

Thanks again for this contribution, @rockwalrus!

There's currently at least one failing test:

1) [workbox-window] Workbox
       register
         reports all events for an external SW registration:

      controllingSpy
      + expected - actual

      -2
      +1

[jeffposnick]

(I'm happy to fix up the tests if you don't mind.)

[rockwalrus]

(I'm happy to fix up the tests if you don't mind.)

Go ahead! There seems to be some flakiness in the tests on my machine that I haven't been able to isolate yet. Thanks!

[jeffposnick]

So it turns out that I don't have permission to push directly to the StateFarmIns branch used in this PR—I thought that GitHub allowed a repo to push to any fork's branch when there's an open PR, but perhaps your repo is locked extra tight?

In any case, here are the three lines that should get the tests passing in the test/workbox-window/integration/test-all.js file: v6...2857#diff-538225be460da9f1c8e38145ed5058866bf568217386107582e0508a7922966b

Hopefully you can apply that change yourself; otherwise, I think we'd have to close this PR and I would open a new one (giving you credit in the release notes, of course).

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[tropicadri]

By the way this is the person you need to check with about being a verified contributor for the CLA: Elizabeth Fox Anvick (Infrastructure Analyst-Open Systems) elizabeth.foxanvick.lpjz@statefarm.com

[rockwalrus]

So it turns out that I don't have permission to push directly to the StateFarmIns branch used in this PR—I thought that GitHub allowed a repo to push to any fork's branch when there's an open PR, but perhaps your repo is locked extra tight?

I swear that used to be possible, but it's possible something has been changed.

In any case, here are the three lines that should get the tests passing in the test/workbox-window/integration/test-all.js file: v6...2857diff-538225be460da9f1c8e38145ed5058866bf568217386107582e0508a7922966b

Hopefully you can apply that change yourself; otherwise, I think we'd have to close this PR and I would open a new one (giving you credit in the release notes, of course).

Merged and pushed.

[rexb1971]

By the way this is the person you need to check with about being a verified contributor for the CLA: Elizabeth Fox Anvick (Infrastructure Analyst-Open Systems) elizabeth.foxanvick.lpjz@statefarm.com

Elizabeth has moved to another position in the company and no longer seems to have access to this group. How do we go about recovering access to https://groups.google.com/d/forum/state-farm-insurance?

[jeffposnick]

Thanks again for contributing this change! There is some unrelated flakiness in the workbox-broadcast-update tests that I'll look into separate from this PR, so as not to delay things further.