Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use chokidar 3.x directly #2913

Merged
merged 2 commits into from
Aug 19, 2021
Merged

Use chokidar 3.x directly #2913

merged 2 commits into from
Aug 19, 2021

Conversation

jeffposnick
Copy link
Contributor

R: @tropicadri

Fixes #2912

This uses the latest chokidar 3.x directly, instead of relying on the glob-watcher wrapper which used chokidar 2.x under the hood. This resolves some compatibility issues with chokidar 2.x.

In the course of making these changes, I also realized that workbox-cli wasn't properly reading the new workbox-build TypeScript definitions, as it had an override module in place. This PR removes that override module and takes better advantage of the new types internally.

Since workbox-cli is run as a transpiled binary and not intended to be loaded as a module by third-party code, I think that swapping out the internal type definitions should be considered a non-breaking change.

@jeffposnick jeffposnick requested a review from tropicadri August 12, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vulnerability CVE-2020-28469 is introduced in workbox-cli
2 participants