Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing dynamic method calling to prevent minification error #3012

Merged
merged 1 commit into from
Jan 10, 2022
Merged

removing dynamic method calling to prevent minification error #3012

merged 1 commit into from
Jan 10, 2022

Conversation

tropicadri
Copy link
Contributor

Fixes #3006

Because I'm not sure how to reliably test the declare approach, I went with calling the methods explicitly.

@tropicadri tropicadri requested a review from jeffposnick January 8, 2022 01:07
jeffposnick
jeffposnick approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@jeffposnick jeffposnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@jeffposnick jeffposnick merged commit b14bdb4 into v6 Jan 10, 2022
@jeffposnick jeffposnick deleted the mini branch January 10, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffposnick jeffposnick jeffposnick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamic method calls in Queue.ts could fail with minification
2 participants
@tropicadri @jeffposnick