Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temp leading slash #627

Merged
merged 2 commits into from
Jun 13, 2017
Merged

Temp leading slash #627

merged 2 commits into from
Jun 13, 2017

Conversation

gauntface
Copy link

R: @jeffposnick @addyosmani

Fixes #560

This fixes up the remaining tests from @happyahluwalia's PR

happyahluwalia and others added 2 commits June 12, 2017 21:15
@happyahluwalia
Fix for #560 leading slash added to files in manifest (#589)
d5b96ca 
* Fix for #560 leading slash added to files in manifest

* Issue #560 end to end test updated to remove leading /

* Issue #560 One test case also appended a leading slash, updated the test case

* Preceeding slash is required in case of templateURL

* Fix for #560 removing leading slash
Fixing up the remaining issues with leading slash change
4f5756b
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@jeffposnick jeffposnick merged commit 43b1ea3 into master Jun 13, 2017
@jeffposnick jeffposnick deleted the temp-leading-slash branch June 13, 2017 18:54
@snyk-bot snyk-bot mentioned this pull request May 29, 2020
Open
@Jeremip11 Jeremip11 mentioned this pull request Dec 22, 2022
Open
@donavon donavon mentioned this pull request Dec 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffposnick jeffposnick jeffposnick approved these changes

@addyosmani addyosmani Awaiting requested review from addyosmani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Service worker generated using workbox-cli have a leading / on all cache urls
4 participants
@gauntface @googlebot @jeffposnick @happyahluwalia