Rename cacheWillMatch to cachedResponseWillBeUsed #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffposnick
commented
Aug 15, 2017
| @@ -31,7 +31,7 @@ describe('Tests for the handle-range-request.js functions', function() { | |||
| const reader = new FileReader(); | |||
| const finished = new Promise((resolve) => { | |||
| reader.addEventListener('loadend', (event) => { | |||
| resolve(event.srcElement.result); | |||
| resolve(event.target.result); | |||
There was a problem hiding this comment.
This isn't related to the core change in this PR, but the Firefox tests were flakey when I ran them locally before switching to target. Not sure why it wasn't an issue before, though...
gauntface
approved these changes
Aug 15, 2017
gauntface
pushed a commit
that referenced
this pull request
Aug 24, 2017
* Adds JSDocs for the lifecycle methods, and awaits the return of each. (#736) * Move towards using 'workbox' over 'workbox-cli'. (#744) * New library to support Range requests (#710) * WIP. * Still needs JSDocs. * Renaming, bug fixes, JSDoc. * Changed a few comments. * Updated tests to use new bundling infra, allowing us to remove private exports. * Modified a warning. * Rename cacheWillMatch to cachedResponseWillBeUsed (#748) * No longer register a fetch handler for each Router by default (#752) * No longer register a fetch handler for each Router by default. * Review feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @addyosmani @gauntface
Fixes #713