Adding the route logic #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffposnick
suggested changes
Oct 13, 2017
| * | ||
| * @return {Array<string>} An array of URLs. | ||
| */ | ||
| async getCachedUrls() { |
There was a problem hiding this comment.
I'm thinking that it would be safer to always go through the steps of creating a fresh array of URLs and not saving and reusing the previous this._parsedCacheUrls value, since the underlying this._entriesToCacheMap value might be changed at any time.
Alternatively, you could set this._parsedCacheUrls to null whenever this._entriesToCacheMap is modified, but that's probably overkill.
(This might have been an issue with v2, too.)
There was a problem hiding this comment.
Just changed it to always return a fresh array.
PR-Bot Size PluginChanged File Sizes
New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size Plugin
|
jeffposnick
approved these changes
Oct 14, 2017
|
LGTM2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @jeffposnick @addyosmani
This implements #886 minus tests. Wanted to get a gut check on the approach and will add tests in a follow up PR.