Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure untranspiled node 4+ compat for the v2 webpack plugin #966

Merged
merged 1 commit into from
Nov 1, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/workbox-webpack-plugin/index.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict';

const swBuild = require('workbox-build');
const path = require('path');
const url = require('url');
Expand Down Expand Up @@ -63,7 +65,7 @@ class WorkboxBuildWebpackPlugin {
}

if (compilation.options.output.publicPath) {
const {publicPath} = compilation.options.output;
const publicPath = compilation.options.output.publicPath;
const compiledAssets = [];
for (let key in compilation.assets) {
if (Object.prototype.hasOwnProperty.call(compilation.assets, key)) {
Expand Down