Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce package size by omitting tests & build tools #108

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Reduce package size by omitting tests & build tools #108

merged 1 commit into from
Feb 24, 2020

Conversation

NotWoods
Copy link
Contributor

  • Moved some dependencies to devDependencies
  • Removed dist/spec from shipped files in core
  • Used promisify with extractZip
  • Deleted unused copy of bin/llama-pack

PEConn
PEConn approved these changes Feb 24, 2020
View reviewed changes
Copy link
Collaborator

@PEConn PEConn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @andreban what do you think

@andreban
Copy link
Member

andreban commented Feb 24, 2020 via email

andreban
andreban approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@andreban andreban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

@andreban andreban merged commit 4cd66f9 into GoogleChromeLabs:master Feb 24, 2020
@andreban andreban added the enhancement New feature or request label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreban andreban andreban approved these changes

@PEConn PEConn PEConn approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NotWoods @andreban @PEConn