Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom jimp build #41

Merged
merged 1 commit into from
Nov 29, 2019
Merged

Use custom jimp build #41

merged 1 commit into from
Nov 29, 2019

Conversation

NotWoods
Copy link
Contributor

Jimp recently released support for using parts of it independently. This PR shrinks the install size by removing all unneeded plugins.

@PEConn
Copy link
Collaborator

PEConn commented Nov 29, 2019

Hey Tiger, thanks for this change!

Can you explain how it works? It seems you just set up some config - where does Jimp actually do stuff?

@NotWoods
Copy link
Contributor Author

This replaces the 'jimp' module that I previously added. Jimp is used for image resizing here but has many additional features, and the custom config strips those out and only downloads the resize plugin.

Copy link
Collaborator

@PEConn PEConn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh gotcha - I missed jimp being added, thought this was the CL that added it.

LGTM

@andreban andreban merged commit 24a9e5e into GoogleChromeLabs:master Nov 29, 2019
@andreban andreban added documentation Improvements or additions to documentation internal and removed documentation Improvements or additions to documentation labels Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants