-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support WebManifest shortcuts when generating the TWA #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the UX here? We're prompting to ask if the developer wants to include shortcuts and then what?
What if the developer selects yes and there are no shortcuts in the web manifest? Do we let them specify some?
I had an offline conversation with @andreban about this. Currently, we just ask whether users want to include shortcuts or not. They can't set it themselves. If we do end up going down that path, we will need to explore some UI possibilities, as it's not that easy to set them up via a CLI. It's easier to pass a file manifest if you want to customize shortcuts in a way that differs from the published Web Manifest. If they select yes and there are no shortcuts, nothing happens. |
Yes, filling a shortcuts section from the prompt might make things complicated (maybe we could make it optional later). It's possible to add an I wonder if we should show developers the content of the existing shortcuts before asking them to confirm. |
No description provided.