Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Android 13 themed icons #650

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add support for Android 13 themed icons #650

wants to merge 2 commits into from

Conversation

NotWoods
Copy link
Contributor

@NotWoods NotWoods commented Feb 11, 2022 •
edited
Loading

Android 13 introduces an API for Themed Icons, which are monochrome icons on a colored background. This change adds support to create those icons from a web app manifest.

Note that Android requires an Adaptive Icon for this to work. Consequently, you must have a maskable icon AND a monochrome icon.

Tested with https://monochrome.fyi/manifest.json

Screenshot of Android 13 homescreen with "Monochrome" PWA icon. All icons are themed, including the PWA.

@andreban
Copy link
Member

Code looks good to me. I wonder if we'd like to have this behind a feature flag, since Android 13 is still beta and APIs might change. @PEConn and @nohe427 for thoughts.

@PEConn
Copy link
Collaborator

PEConn commented Feb 14, 2022

Code looks good to me - I agree with Andre about putting this behind a flag until the Android 13 APIs are fixed.

@andreban andreban added the enhancement New feature or request label Mar 24, 2022
@Stevie-Ray
Copy link

Hi @NotWoods and @andreban , two days ago we had the official release of Android 13 for Pixel devices.

https://developer.android.com/about/versions/13

Would be nice if this feature could be implemented so my apps will fit with the new themes icons.

Anyways thanks for your amazing work and making this possible!

@dartess
Copy link

dartess commented Dec 15, 2022

is it worth adding some description to the readme?

@ashnohe
Copy link

ashnohe commented Dec 19, 2022

hey all! love this PR. It would be awesome if this could be approved and merged now that Android 13 is no longer in beta :)

@FluorescentHallucinogen
Copy link
Contributor

@PEConn @andreban Is there anything left that prevents this pull request from merging?

@andreban
Copy link
Member

andreban commented Feb 3, 2023

I haven't tested it since Android 13 came out of beta. If anyone has a chance to do it and let me know if it works, happy to merge.

@FluorescentHallucinogen
Copy link
Contributor

@andreban

If anyone has a chance to do it and let me know if it works, happy to merge.

Could you please rebase this PR and publish alpha npm package for this branch (like ardatan/graphql-tools#2065 (comment)) for easier testing by more people?

Is that exactly what the publish-canary script in package.json does? 🤔

@andreban
Copy link
Member

Yep, that's what publish-canary does.

andreban
andreban approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@andreban andreban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@NotWoods NotWoods mentioned this pull request May 28, 2023
Closed
@maiconcarraro maiconcarraro mentioned this pull request Jul 24, 2024
Merged
3 tasks
jgw96 pushed a commit to pwa-builder/PWABuilder that referenced this pull request Jul 29, 2024
@maiconcarraro
fix: doc misleading for google play package (#4779)
7565c9c 
fixes a misleading statement that can be a problem to new users,
example: [thread
discord](https://discord.com/channels/930156205542883409/1265639864246996992/1265672310287892560)

## PR Type
<!-- Please uncomment one ore more that apply to this PR -->

- Documentation content changes


## Describe the current behavior?
<!-- Please describe the current behavior that is being modified or link
to a relevant issue. -->
- The android docs are outdated compared to the builder forms page and
tooltips.


## Describe the new behavior?
- Docs synced with page/tooltips.  

![image](https://github.com/user-attachments/assets/918eb610-0dc4-4d2d-860a-92168dcdb514)


## PR Checklist

- [X] Test: run `npm run test` and ensure that all tests pass
- [X] Target main branch (or an appropriate release branch if
appropriate for a bug fix)
- [ ] Ensure that your contribution follows [standard accessibility
guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design).
Use tools like https://webhint.io/ to validate your changes.


## Additional Information
- Also added an additional note for monochrome icons which won't work as
themed icons because it's missing the support from bubblewrap here:
GoogleChromeLabs/bubblewrap#650
@jahed
Copy link

jahed commented Sep 10, 2024 •
edited
Loading

I'm guessing this is waiting for WebAPK to support themed icons first? If so, looks like it's blocked: https://issues.chromium.org/issues/40277264

Android currently doesn't support themed icons for dynamically created shortcuts, so we can't use the monochrome icons for PWAs.

@NotWoods
Copy link
Contributor Author

The WebAPK system is separate. I've also commented in the issue tracker that sinansahin's comment was inaccurate as WebAPK and bubblewrap create launcher icons, not dynamic shortcuts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreban andreban andreban approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@NotWoods @andreban @PEConn @Stevie-Ray @dartess @ashnohe @FluorescentHallucinogen @jahed